Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectMapper.construct: Output the exception message as well #220

Merged

Conversation

t-b
Copy link
Contributor

@t-b t-b commented Dec 13, 2019

This is much more helpful for debugging.

This is much more helpful for debugging.
@oruebel oruebel merged commit 1a01604 into hdmf-dev:dev Dec 13, 2019
@t-b t-b deleted the feature/enhance-object-mapper-exception-message branch December 13, 2019 17:47
@rly
Copy link
Contributor

rly commented Dec 18, 2019

@t-b the underlying error message is nested (raise ex2 from ex1) and should still be output as well. Is it necessary to copy it into ex2's error message?

@t-b
Copy link
Contributor Author

t-b commented Dec 18, 2019

@rly Yes the error messages can be a bit verbose for the case you are describing. Is that a problem?

@rly
Copy link
Contributor

rly commented Dec 18, 2019

@t-b No, it is fine. I was just curious what the rationale was given that the inner error message should be printed to stderr as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants